-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RayService] Support Incremental Zero-Downtime Upgrades #3166
Open
ryanaoleary
wants to merge
14
commits into
ray-project:master
Choose a base branch
from
ryanaoleary:incremental-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
5 tasks
Signed-off-by: Ryan O'Leary <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements an alpha version of the RayService Incremental Upgrade REP.
The RayService controller logic to reconcile a RayService during an incremental upgrade is as follows:
IncrementalUpgradeOptions
and accept/reject the RayService CR accordinglyreconcileGateway
- on the first call this should create a new Gateway CR and subsequent calls will update theListeners
as necessary based on any changes to the RayService.SpecreconcileHTTPRoute
- on the first call this should create a HTTPRoute CR with twobackendRef
s, one pointing to the old cluster and one to the pending cluster withweight
s 100 and 0 accordingly. Every subsequent call toreconcileHTTPRoute
will update the HTTPRoute by changing theweight
of eachbackendRef
byStepSizePercent
until theweight
associated with each cluster equals theTargetCapacity
associated with that cluster. ThebackendRef
weight is exposed through the RayService Status fieldTrafficRoutedPercent
. Theweight
is only changed if it's been at leastIntervalSeconds
sinceRayService.Status.LastTrafficMigratedTime
, otherwise the controller waits until the next iteration and checks again.TrafficRoutedPercent == TargetCapacity
, if so thetarget_capacity
can be updated for one of the clusters.reconcileServeTargetCapacity
. If the totaltarget_capacity
of both Serve configs is less than or equal to 100%, the pending cluster'starget_capacity
can be safely scaled up byMaxSurgePercent
. If the totaltarget_capacity
is greater than 100%, the active clustertarget_capacity
can be decreased byMaxSurgePercent
.TargetCapacity
andTrafficRoutedPercent
of the pending RayService instance RayCluster equal 100%, the upgrade is complete.Related issue number
Checks