Skip to content

Conversation

Totto16
Copy link

@Totto16 Totto16 commented Oct 4, 2024

  • I added support for the TXT sentence formatter (according to this)
  • It supports multi and single sentences (see test cases)
  • I added tests for it.
  • I tested it on real hardware (with added TXT Parser #40)

This is related to #40

@infusion
Copy link
Collaborator

Sorry for the long standing PR. After a bigger refactoring your great PR did not fit anymore. And I also did not like the optional passing of the instance to the static method. I built on your PR an own implementation and thank you a lot anyway for your work! Hope everything works fine on your site with the new gps.js version

@infusion infusion closed this Aug 14, 2025
@Totto16
Copy link
Author

Totto16 commented Aug 14, 2025

Sorry for the long standing PR. After a bigger refactoring your great PR did not fit anymore. And I also did not like the optional passing of the instance to the static method. I built on your PR an own implementation and thank you a lot anyway for your work! Hope everything works fine on your site with the new gps.js version

Thanks, if this PR at least helped to build a TXT parser I am totally fine with it, this is open source, so no need to apologize for long waits 😉

I haven't tested it yet, but if I find some error I'll report it 😃

Thanks for this amazing library anyway ❤️

@infusion
Copy link
Collaborator

Thanks for your kind words! Would you mind telling me what receiver you're using that spits out these TXT sentences?

@Totto16
Copy link
Author

Totto16 commented Aug 18, 2025

Thanks for your kind words! Would you mind telling me what receiver you're using that spits out these TXT sentences?

I bought a simple gps stick (this one: https://www.amazon.com/dp/B07SMRXSC8)

I have not tested it yet, if it works with the new library, but I'll do that today, 😄

@infusion
Copy link
Collaborator

Ah interesting! I got plenty of receivers, but not this one. If you find the time I'd be interested if all sentences are parsed without a problem. Don't hesitate to open a new ticket if something is not parsed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants