Add Actions to Desktop Notifications #84
Merged
+82
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the implementation of the _show_notif_success() function to handle the arguments eventually given to notify-send to show a desktop notification on supported platforms when a new project is initialized. The actual invocation of notify-send is moved to a new internal function _show_notif_success_impl() so that the invocation can be pushed to the background, since notify-send will block until the notification is dismissed or an action button is pressed by the user.
This is used to allow addons to customize the branding via addons when their own applications when they integrate with project-init. Signed-off-by: kilo52 <[email protected]>
Signed-off-by: kilo52 <[email protected]>
Is added to check for available notify-send version to make sure that actions are supported, before adding them to the notication arguments when displaying the success desktop notication. Signed-off-by: kilo52 <[email protected]>
Fixed masking return value. Disabled linter complaint for known version value format. Added return status check for notify-send command and early return. Signed-off-by: kilo52 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds notification actions to the success desktop notifications.
Changes the implementation of the
_show_notif_success()function to handle the arguments eventually given to notify-send to show a desktop notification on supported platforms when a new project is initialized. The actual invocation of notify-send is moved to a new internal function_show_notif_success_impl()so that the invocation can be pushed to the background, sincenotify-sendwill block until the notification is dismissed or an action button is pressed by the user.