RATESWSX-162: add support for multiple tracking ids #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriarte-mendez
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
Hi @rommelfreddy
there could be some problem using count on newer PHP versions.
it would be nice if you change the runner in .github/workflows/push.yml:
ubuntu-18.04 instead of ubuntu-latest to allow other checks to run.
| public function setProvider($provider) | ||
| { | ||
| $ids = $this->getIds(); | ||
| if (count($ids[0]) === null) { |
There was a problem hiding this comment.
count on null will throw error on PHP 7.3+
There was a problem hiding this comment.
$ids[0] is also bullsh*t. :)
fixed the whole line.
There was a problem hiding this comment.
@eiriarte-mendez changed the ubuntu-version in separate PR:
#17
(but why? - please see my comment in the PR)
eiriarte-mendez
approved these changes
Mar 10, 2021
hamail-tahir
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @MartinKuhl