Skip to content

Conversation

tdewey-rpi
Copy link
Contributor

  • Introduced a new directory for splash screen examples, including a configuration file and documentation.
  • Added a YAML configuration file for splash screen settings, allowing customization of the splash image and boot parameters.
  • Created documentation detailing the features, usage, and technical requirements of the splash screen layer.
  • Included an example script for generating a simple splash screen image using ImageMagick.

- Introduced a new directory for splash screen examples, including a configuration file and documentation.
- Added a YAML configuration file for splash screen settings, allowing customization of the splash image and boot parameters.
- Created comprehensive documentation detailing the features, usage, and technical requirements of the splash screen layer.
- Included an example script for generating a simple splash screen image using ImageMagick.
@tdewey-rpi tdewey-rpi requested a review from learmj October 10, 2025 16:55
- Expanded the splash-demo.yaml file with comprehensive comments and instructions for creating and using a custom boot splash screen on Raspberry Pi OS.
- Included steps for building the image and generating the splash screen image, enhancing usability for developers.
echo "Configuring splash screen from $SPLASH_IMAGE" >&2

# Build command arguments
if igconf isy splash_skip_image_checks && ! igconf isy splash_update_cmdline ; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to use igconf here to test variables, but it's more defensive to use set -u and reference the variable directly (eg testing $IGconf_splash_skip_image_checks). For example, if the X-Env-Var declaration was changed or there was a typo, it would be easy to miss in the scripting logic with igconf, whereas it would result in a hard failure if the variable was referenced by name. Using X-Env-Var-*-Set = y will always ensure the variable has a value.

@@ -0,0 +1,81 @@
# METABEGIN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The splash layer and associated assets would be more applicable under layer/rpi/device/, as splash is a device specific feature. I could imagine Connect and OTA etc residing under layer/rpi/device/services/.
Just trying to keep compartmentalisation of layers in mind as we add them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, however - this is a kernel feature, not a device feature. It's in no way dependent on the Raspberry Pi device you are using.

@learmj
Copy link
Collaborator

learmj commented Oct 13, 2025

Tom - this is fantastic. Thank you. Just one suggestion about the location of the splash layer and assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants