-
Notifications
You must be signed in to change notification settings - Fork 137
Make no libusb build clearer #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Might also be worth modifying the |
Do you mean this bit?
This already changes when you don't have libusb to
|
Yeah, I was thinking that it might be nice to also display the "This version of picotool was compiled without USB support. Some commands are not available." text when running |
Ah, I'd actually been explicit not to do that (the |
@@ -114,6 +114,10 @@ static const string rp2350_arm_s_family_name = "rp2350-arm-s"; | |||
static const string rp2350_arm_ns_family_name = "rp2350-arm-ns"; | |||
static const string rp2350_riscv_family_name = "rp2350-riscv"; | |||
|
|||
#if !HAS_LIBUSB | |||
static const string libusb_not_found_message = "\nThis version of picotool was compiled without USB support. Some commands are not available.\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nitpick, but IMHO libusb_not_found_message
makes it sound like it's looking for libusb at runtime? built_without_libusb_message
might be slightly better? 🤷
Fix info and config help text without libusb, add no USB support messages to command line parsing errors, and add no USB support message to
picotool version
Eg, the output from
picotool info
is nowor
picotool load
Fixes #245