Skip to content

Added Waveshare RP2350 PiZero board header #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added Waveshare RP2350 PiZero board header #2674

wants to merge 1 commit into from
+82 −0

Conversation

drewpo28
Copy link

Added Waveshare RP2350 PiZero board header

@github-actions GitHub Actions
Copy link

Please do not submit against master, use develop instead

@drewpo28 drewpo28 mentioned this pull request Sep 16, 2025
Closed
@lurch lurch changed the base branch from master to develop September 16, 2025 23:39
@lurch lurch self-assigned this Sep 16, 2025
lurch
lurch reviewed Sep 16, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Please do not submit against master, use develop instead

@drewpo28 drewpo28 force-pushed the master branch 3 times, most recently from 4e23bf7 to aefc3a9 Compare September 17, 2025 06:54
lurch
lurch reviewed Sep 17, 2025
View reviewed changes
lurch
lurch reviewed Sep 17, 2025
View reviewed changes
lurch
lurch reviewed Sep 17, 2025
View reviewed changes
lurch
lurch reviewed Sep 17, 2025
View reviewed changes
@lurch
Copy link
Contributor

lurch commented Sep 17, 2025 

  +-+---------------- 1 ----------------
    | Exception: src/boards/include/boards/waveshare_rp2350_pizero.h:30  PICO_DEFAULT_UART_TX_PIN is set to 4 which isn't a valid pin for TX on UART 0
    +---------------- 2 ----------------
    | Exception: src/boards/include/boards/waveshare_rp2350_pizero.h:33  PICO_DEFAULT_UART_RX_PIN is set to 5 which isn't a valid pin for RX on UART 0
    +------------------------------------

Perhaps you need to change PICO_DEFAULT_UART to 1? (Using Table 3 from https://datasheets.raspberrypi.com/rp2350/rp2350-datasheet.pdf as a cross-reference)

@lurch lurch removed their assignment Sep 18, 2025
lurch
lurch approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch approved these changes

Assignees
No one assigned
Labels
board settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewpo28 @lurch