imx219 support for 4 CSI2 data lanes #6615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6by9
force-pushed
the
rpi-6.12.y-imx219
branch
from
513fb11 to
b8d5f91
Compare
popcornmix
force-pushed
the
rpi-6.12.y
branch
from
c2ec0c0 to
005644c
Compare
|
Looks good to me! I gave it a go on my pi and frame rates were spot on :) |
|
Thank you. I'll send it upstream and sort the downstream PRs on Monday. |
Commit ceddfd4 ("media: i2c: imx219: Support four-lane operation") added support for device tree to allow configuration of the sensor to use 4 lanes with a link frequency of 363MHz, and amended the advertised pixel rate to 280.8MPix/s. However it didn't change any of the PLL settings, so actually it would have been running effectively overclocked in the MIPI block, and with the frame rate and exposure calculations being wrong. The pixel rate and link frequency advertised were taken from the "Clock Setting Example" section of the datasheet. However those are based on an external clock of 12MHz, and are unachievable with a clock of 24MHz (it seems PREPLLCLK_VT_DIV and PREPLLCK_OP_DIV can ONLY be set via the automatic configuration doumented in "9-1-2 EXCK_FREQ setting depend on INCK frequency). Dropping all support for the 363MHz link frequency would cause problems for existing users, so allow it from device tree, but log a warning that the requested value is not being truly applied. Fixes: ceddfd4 ("media: i2c: imx219: Support four-lane operation") Co-developed-by: Peyton Howe <[email protected]> Signed-off-by: Peyton Howe <[email protected]> Signed-off-by: Dave Stevenson <[email protected]>
Signed-off-by: Peyton Howe <[email protected]>
6by9
force-pushed
the
rpi-6.12.y-imx219
branch
from
b8d5f91 to
0133d45
Compare
|
Updated this PR for 6.12. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 21, 2025
kernel: imx219 support for 4 CSI2 data lanes See: raspberrypi/linux#6615 kernel: rpi-6.6.y - imx219 4 lane support See: raspberrypi/linux#6618 kernel: dtoverlays: waveshare-panel: Disable new touch controller by default See: raspberrypi/linux#6619
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 21, 2025
kernel: imx219 support for 4 CSI2 data lanes See: raspberrypi/linux#6615 kernel: rpi-6.6.y - imx219 4 lane support See: raspberrypi/linux#6618 kernel: dtoverlays: waveshare-panel: Disable new touch controller by default See: raspberrypi/linux#6619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpi-6.12.y version of #6580 and #6575
I happened to be on a 6.12 branch, and want to upstream this, hence targeting the more recent kernel. I'll backport to 6.6 in due course.
@peyton-howe are you happy with the contents? I'll be upstreaming the driver patch with your name in the Co-developed tags as per the commit text so you get the appropriate credit.