drm: rp1: rp1-dpi: Fix optional dependency on RP1_PIO #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Purported fix for #6529, in testing with various defconfigs... |
|
I think you want |
|
Ah yes, I think I do want that. At the Kconfig level, this documentation suggests there's already a trap for built-in depending on module (though it's far from obvious from the syntax how it achieves that...) |
njhollinghurst
force-pushed
the
dpi-interlace-optional
branch
from
1a750cb to
60f3b09
Compare
pelwell
approved these changes
Dec 12, 2024
|
LGTM |
|
Tested and works as expected with |
Add optional dependency to Kconfig, and conditionally compile PIO-dependent code. Add a mode validation function to reject interlaced modes when RP1_PIO is not present. Signed-off-by: Nick Hollinghurst <[email protected]>
njhollinghurst
force-pushed
the
dpi-interlace-optional
branch
from
60f3b09 to
d0bf7a7
Compare
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 16, 2024
kernel: RP1 DPI: Add interlaced modes See: raspberrypi/linux#6529 kernel: ASoC: allo-piano-dac-plus: Fix volume limit locking See: raspberrypi/linux#6532 kernel: drm: vc4: txp: Do not allow 24bpp formats when transposing See: raspberrypi/linux#6533 kernel: ASoC: allo-piano-dac-plus: Suppress -517 errors See: raspberrypi/linux#6534 kernel: drm: rp1: rp1-dpi: Fix optional dependency on RP1_PIO See: raspberrypi/linux#6535 kernel: serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND See: raspberrypi/linux#6540
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 16, 2024
kernel: RP1 DPI: Add interlaced modes See: raspberrypi/linux#6529 kernel: ASoC: allo-piano-dac-plus: Fix volume limit locking See: raspberrypi/linux#6532 kernel: drm: vc4: txp: Do not allow 24bpp formats when transposing See: raspberrypi/linux#6533 kernel: ASoC: allo-piano-dac-plus: Suppress -517 errors See: raspberrypi/linux#6534 kernel: drm: rp1: rp1-dpi: Fix optional dependency on RP1_PIO See: raspberrypi/linux#6535 kernel: serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND See: raspberrypi/linux#6540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional dependency to Kconfig, and conditionally compile PIO-dependent code. Add a mode validation function to reject interlaced modes when RP1_PIO is not present.