Remove 2712 SDHCI accessors #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popcornmix
force-pushed
the
rpi-6.6.y
branch
2 times, most recently
from
758a65d to
8f7263f
Compare
The reason for adding these are lost to the mists of time (and for a previous chip revision). Removing these accessors appears to have no ill effect on production chips, so get rid of the unnecessary RMW cycles. Signed-off-by: Jonathan Bell <[email protected]>
P33M
force-pushed
the
remove_sdhc_accessors
branch
from
39d6ff0 to
c1aaca4
Compare
|
Should the second commit be in its own PR? |
P33M
force-pushed
the
remove_sdhc_accessors
branch
from
c1aaca4 to
8a15e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by an email discusson from a freeBSD user, there doesn't seem to be a need to guard register accesses on C1 parts.
A full apt update and fio benchmark went fine with these removed, whereas if these were required, the controller usually falls over when attempting to mount the filesystem.