Add link freq Control for IMX519 and Arducam64MP #5841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6by9
reviewed
Jan 10, 2024
drivers/media/i2c/arducam_64mp.c
Outdated
| 0, | ||
| arducam_64mp_link_freq_menu); | ||
| if (arducam_64mp->link_freq) | ||
| arducam_64mp->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; |
There was a problem hiding this comment.
If you're only needing the struct v4l2_ctrl for setting the READ_ONLY flag, then store it as a local to this function rather than in the sensor's state.
drivers/media/i2c/imx519.c
Outdated
| ARRAY_SIZE(imx519_link_freq_menu) - 1, 0, | ||
| imx519_link_freq_menu); | ||
| if (imx519->link_freq) | ||
| imx519->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; |
added 2 commits
January 10, 2024 17:44
Add V4L2_CID_LINK_FREQ as a read-only control with a value of 408 Mhz. This will be used by the CFE driver to corretly setup the DPHY timing parameters in the CSI-2 block. Signed-off-by: Lee Jackson <[email protected]>
Add V4L2_CID_LINK_FREQ as a read-only control with a value of 456 Mhz. This will be used by the CFE driver to corretly setup the DPHY timing parameters in the CSI-2 block. Signed-off-by: Lee Jackson <[email protected]>
ArduCAM
force-pushed
the
arducam_add_link_freq
branch
from
56ff947 to
5898017
Compare
|
LGTM - thanks for the updates. You're right it did get added to imx477 back in Nov 2023. I can't find the PR for it, as I would have made the same comment had I seen the PR. |
It looks like it was a direct push. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 10, 2024
kernel: ARM: dts: bcm2712-rpi-5-b: Add eth_ledx parameters See: raspberrypi/linux#5826 kernel: ARM: dts: bcm2712-rpi-5-b: Add fan speed dtparams See: raspberrypi/linux#5822 kernel: drm/vc4: don't check if plane->state->fb == state->fb See: raspberrypi/linux#5832 kernel: spi: bcm2835: Support spi0-0cs and SPI_NO_CS mode See: raspberrypi/linux#5837 kernel: Add link freq Control for IMX519 and Arducam64MP See: raspberrypi/linux#5841 kernel: watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling See: raspberrypi/linux#5838
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 10, 2024
kernel: ARM: dts: bcm2712-rpi-5-b: Add eth_ledx parameters See: raspberrypi/linux#5826 kernel: ARM: dts: bcm2712-rpi-5-b: Add fan speed dtparams See: raspberrypi/linux#5822 kernel: drm/vc4: don't check if plane->state->fb == state->fb See: raspberrypi/linux#5832 kernel: spi: bcm2835: Support spi0-0cs and SPI_NO_CS mode See: raspberrypi/linux#5837 kernel: Add link freq Control for IMX519 and Arducam64MP See: raspberrypi/linux#5841 kernel: watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling See: raspberrypi/linux#5838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.