spi: bcm2835: Support spi0-0cs and SPI_NO_CS mode #5837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forced conversion of native CS lines into software CS lines is done whether or not the controller has been given any CS lines to use. This breaks the use of the spi0-0cs overlay to prevent SPI from claiming any CS lines, particularly with spidev which doesn't pass in the SPI_NO_CS flag at creation. Use the presence of an empty cs-gpios property as an indication that no CS lines should be used, bypassing the native CS conversion code. See: raspberrypi#5835 Signed-off-by: Phil Elwell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 10, 2024
kernel: ARM: dts: bcm2712-rpi-5-b: Add eth_ledx parameters See: raspberrypi/linux#5826 kernel: ARM: dts: bcm2712-rpi-5-b: Add fan speed dtparams See: raspberrypi/linux#5822 kernel: drm/vc4: don't check if plane->state->fb == state->fb See: raspberrypi/linux#5832 kernel: spi: bcm2835: Support spi0-0cs and SPI_NO_CS mode See: raspberrypi/linux#5837 kernel: Add link freq Control for IMX519 and Arducam64MP See: raspberrypi/linux#5841 kernel: watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling See: raspberrypi/linux#5838
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 10, 2024
kernel: ARM: dts: bcm2712-rpi-5-b: Add eth_ledx parameters See: raspberrypi/linux#5826 kernel: ARM: dts: bcm2712-rpi-5-b: Add fan speed dtparams See: raspberrypi/linux#5822 kernel: drm/vc4: don't check if plane->state->fb == state->fb See: raspberrypi/linux#5832 kernel: spi: bcm2835: Support spi0-0cs and SPI_NO_CS mode See: raspberrypi/linux#5837 kernel: Add link freq Control for IMX519 and Arducam64MP See: raspberrypi/linux#5841 kernel: watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling See: raspberrypi/linux#5838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forced conversion of native CS lines into software CS lines is done whether or not the controller has been given any CS lines to use. This breaks the use of the spi0-0cs overlay to prevent SPI from claiming any CS lines, particularly with spidev which doesn't pass in the SPI_NO_CS flag at creation.
Use the presence of an empty cs-gpios property as an indication that no CS lines should be used, bypassing the native CS conversion code.
See: #5835