ASoC: dwc: Defer bclk_ratio handling to hw_params #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclk_ratio is only a factor in clock producer mode, and needs to override the default value of num_channels * sample_size. Move the bclk_ratio handling into the hw_params method, only latching the value in set_bclk_ratio, to address both of those matters. See: raspberrypi#5817 Signed-off-by: Phil Elwell <[email protected]>
|
This seems to be working as expected, and fixes #5817. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 4, 2024
See: raspberrypi/linux#5823 kernel: ASoC: dwc: Defer bclk_ratio handling to hw_params See: raspberrypi/linux#5819
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 4, 2024
See: raspberrypi/linux#5823 kernel: ASoC: dwc: Defer bclk_ratio handling to hw_params See: raspberrypi/linux#5819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bclk_ratio is only a factor in clock producer mode, and needs to override the default value of num_channels * sample_size. Move the bclk_ratio handling into the hw_params method, only latching the value in set_bclk_ratio, to address both of those matters.
See: #5817