-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pixel format support for pisp #5714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naushir Patuck <[email protected]>
JamesH65
reviewed
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the commit comment, one of these should read RGB?
V4L2_PIX_FMT_BGR48/V4L2_PIX_FMT_BGR48
Yup! |
Add the following formats: - V4L2_PIX_FMT_RGB48/V4L2_PIX_FMT_BGR48 48-bit RGB where each colour sample is 16-bits. - V4L2_PIX_FMT_PISP_COMP1_MONO/V4L2_PIX_FMT_PISP_COMP2_MONO 16-bit to 8-bit pisp compressed monochrome pixel format. Signed-off-by: Naushir Patuck <[email protected]>
Signed-off-by: Naushir Patuck <[email protected]>
Signed-off-by: Naushir Patuck <[email protected]>
LGTM. Tested with OV7251. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 21, 2023
kernel: configs: Add the drivetemp module See: raspberrypi/linux#5717 kernel: overlays: ov5647: cam0 mode should use cam0_reg See: raspberrypi/linux#5723 kernel: New pixel format support for pisp See: raspberrypi/linux#5714 kernel: ASoC: dwc: Remove check in set_bclk_ratio handling See: raspberrypi/linux#5725 kernel: w1: Disable kernel log spam See: https://forums.raspberrypi.com/viewtopic.php?p=2159344
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 21, 2023
kernel: configs: Add the drivetemp module See: raspberrypi/linux#5717 kernel: overlays: ov5647: cam0 mode should use cam0_reg See: raspberrypi/linux#5723 kernel: New pixel format support for pisp See: raspberrypi/linux#5714 kernel: ASoC: dwc: Remove check in set_bclk_ratio handling See: raspberrypi/linux#5725 kernel: w1: Disable kernel log spam See: https://forums.raspberrypi.com/viewtopic.php?p=2159344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.