Make configurable the number of minutes after which the user is no longer considered a new user. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger considered a new user.
Small optimisation.
|
Not sure on this one! Will have to take a closer look, I get the point though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users often connect from different devices (desktop, mobile, tablet, etc.) and from different locations (home, work, etc.). If we send notifications to users more than a minute old, we will generate a lot of false positives.
A simple solution would be to make the number of minutes after which a user is no longer considered a new user configurable in order to increase that time.
In my case, increasing that amount to a week (60 * 24 * 7) or a month (60 * 24 * 30) would greatly reduce false positives.
Thank you very much.