Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if geoip is installed #115

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Check if geoip is installed #115

wants to merge 4 commits into from

Conversation

howdu
Copy link

@howdu howdu commented Feb 9, 2025

If the geoip package is optional the location should default to false, otherise you must publish config and change this manually.

For backwards compatibility updated this to check if geoip function exists.

@lrljoe
Copy link
Collaborator

lrljoe commented Mar 1, 2025

just need to review any impacts from the secondary change, and look at location overall from a headers perspective, but the change overall makes sense.

However can I ask that you kindly split the PR into two, so that the change for the failed login listener is separate to this.

Wholly appreciate both fixes, just want to make sure its managed

Finally, please target develop for the PR, as that's where changes go first

@lrljoe lrljoe changed the base branch from main to develop March 1, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants