Skip to content

Conversation

howdu
Copy link

@howdu howdu commented Feb 9, 2025

If the geoip package is optional the location should default to false, otherise you must publish config and change this manually.

For backwards compatibility updated this to check if geoip function exists.

@lrljoe
Copy link
Collaborator

lrljoe commented Mar 1, 2025

just need to review any impacts from the secondary change, and look at location overall from a headers perspective, but the change overall makes sense.

However can I ask that you kindly split the PR into two, so that the change for the failed login listener is separate to this.

Wholly appreciate both fixes, just want to make sure its managed

Finally, please target develop for the PR, as that's where changes go first

@lrljoe lrljoe changed the base branch from main to develop March 1, 2025 00:34
@lrljoe
Copy link
Collaborator

lrljoe commented May 24, 2025

I can't merge this in when you're removing the buymeacoffee from the original creator etc.

Not sure why you're trying to remove references etc for this?

@lrljoe
Copy link
Collaborator

lrljoe commented May 24, 2025

I've fixed the issue with the cross-references in the listener.

The package uses optional() for geoip. So it doesn't need to check if method exists in the config (which is also pretty ugly in terms of performance)

@howdu
Copy link
Author

howdu commented May 24, 2025

Ah, sorry — I missed your previous comment but I wasn’t the one who removed the buymeacoffee.

As mentioned earlier, the reason the function exists is for backward compatibility — ideally location should be false by default.

Optional does not prevent the error undefined function geoip(), which's what this PR was to address. See othes who had the same issue: #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants