Fix log creation in the LogoutListener to use correct class #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to use a custom `AuthenticationLog` by overriding the `authentications()` and `latestAuthentication()` methods from the `AuthenticationLoggable` trait, except for this listener which tries creates a new `AuthenticationLog` directly. By going through the User model, we will create an object of the correct (custom) class. This fixes the specific problem of a custom `AuthenticationLog` model that uses the `\Illuminate\Database\Eloquent\Concerns \hasUlids` trait not being successfully created here because it fails to generate the id.
|
Related to #108. |
|
Rebased to develop for merging this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to use a custom
AuthenticationLogby overriding theauthentications()andlatestAuthentication()methods from theAuthenticationLoggabletrait, except for this listener which tries creates a newAuthenticationLogdirectly. By going through the User model, we will create an object of the correct (custom) class.This fixes the specific problem of a custom
AuthenticationLogmodel that uses the\Illuminate\Database\Eloquent\Concerns \hasUlidstrait not being successfully created here because it fails to generate the id.