Skip to content

Add functions to get gpu/cpu/version info, add to benchmark output #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add functions to get gpu/cpu/version info, add to benchmark output #76

wants to merge 1 commit into from

Conversation

@johallar
Copy link
Contributor

@johallar johallar commented Oct 9, 2025 •
edited
Loading

Per discussion here:
https://docs.google.com/document/d/1wD9YDDze5vr3K6kpU4eKwlk55GwvFx9vVTTj_X8nj-w/edit?tab=t.0

Adding properties to behcnmark_result.json to contain:

hardware": {
    "arch": "x86_64",
    "cpu_count": 32,
    "cpu_name": "intel",
    "cpu_memory": 220,
    "gpu_count": 6,
    "gpu_name": "t4",
    "gpu_memory": 15
},
"versions": {
    "version_presto": "b8bb0c888739f337a5e7f80df9b2ee6aeb2286f9",
    "version_velox": "dca16b16d8455630e662716824c7d9afc3af8b7a",
    "version_cuda": "12.2",
    "version_cuda_driver": "535.230.02"
},

@johallar johallar force-pushed the johallar/add_system_info_benchmark_output branch from 2668ecd to a325bee Compare October 9, 2025 15:36
@simoneves simoneves self-requested a review October 18, 2025 01:12
simoneves
simoneves reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

@simoneves simoneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks fine. Unclear on context.

.gitignore
benchmark_output

# Generated Config
presto/docker/config/generated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but drop this and I'll add it to my HERC-82 PR

presto/testing/performance_benchmarks/system_info.py
"""Get total system memory in GB."""
try:
# Read from /proc/meminfo (Linux)
with open("/proc/meminfo", "r") as f:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an ongoing discussion as to the best way to get this value that works reliably on all machines. Take a look at PR #48 for more notes.

presto/testing/performance_benchmarks/system_info.py
check=True
)
# Parse CUDA version from output (typically in header)
# Example: "CUDA Version: 12.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is useful info, but it's also implicit from the driver version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simoneves simoneves simoneves left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johallar @simoneves