fix license metadata in conda packages, remove setuptools configuration #131
+12
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
bug
31 tasks
jameslamb
changed the title
jameslamb
commented
Dec 30, 2025
| open source license and I have the right under that license to submit that work with modifications, whether created in | ||
| whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), | ||
| open source license and I have the right under that license to submit that work with modifications, whether created | ||
| in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), |
Member
Author
There was a problem hiding this comment.
The newer version of markdownlint was unhappy with the length of this line, so this is just slightly moving around line breaks.
If it's important that this remain untouched, I'll look at options in the markdownlint configuration.
There was a problem hiding this comment.
If it is important that this remain untouched, don't we have a way of telling markdownlint to ignore this file?
Member
Author
There was a problem hiding this comment.
Yeah that's exactly what I meant. I don't know if it matters if this is touched or not, hoping you or @jacobtomlinson could tell me.
jameslamb
changed the title
bdice
approved these changes
Dec 31, 2025
ncclementi
approved these changes
Jan 5, 2026
jacobtomlinson
approved these changes
Jan 6, 2026
Member
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#152
The
licensemetadata on the conda packages is not currently getting set:ref; https://anaconda.org/channels/rapidsai/packages/rapids-cli/files
This fixes that. Other changes:
setuptoolsconfiguration inpyproject.toml(this project useshatchling)pre-commithooks to their latest versions