Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff instead of black/flake8/isort #65

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Use ruff instead of black/flake8/isort #65

merged 2 commits into from
Jan 31, 2025

Conversation

KyleFromNVIDIA
Copy link
Contributor

And also rename test/ to tests/ to align with the rest of RAPIDS.

Issue: rapidsai/build-planning#130

@KyleFromNVIDIA
Use ruff instead of black/flake8/isort
2505e8f 
And also rename test/ to tests/ to align with the rest of RAPIDS.
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners January 30, 2025 17:03
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Jan 30, 2025
Merged
jameslamb
jameslamb requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few small recommendations.

pyproject.toml Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/alpha_spec.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
jameslamb
jameslamb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@KyleFromNVIDIA KyleFromNVIDIA merged commit 0e45936 into rapidsai:main Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleFromNVIDIA @jameslamb