Update to 25.10 #248
Draft
Update to 25.10 #248
+96
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
|
It seems likely the cpu test failures for the neural network are also connected to the latest cupynumeric. The objective functions and metrics are all written in cupynumeric and something may have changed. |
|
@RAMitchell, The current error only happens in the CI. I cannot reproduce this yet in my local machine. |
Signed-off-by: Rory Mitchell <[email protected]>
|
Enabling LEGATE_TEST has exposed a bug in the categorical encoder, so I will start there and work forwards. |
Signed-off-by: Rory Mitchell <[email protected]>
|
This bug https://github.com/nv-legate/cupynumeric.internal/issues/1127 is causing test failures in the encoder, I will work around it for now. |
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
Signed-off-by: Rory Mitchell <[email protected]>
|
I have fixed a bunch of bugs and now there are two completely new failures - realm is crashing in the GPU test and cupynumeric is crashing in the CPU test. |
Signed-off-by: Rory Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to push Supun's fix on top of Rory's PR: #244