Skip to content

Conversation

@mroeschke
Copy link
Contributor

Description

Towards #18659

  • The MultiIndex tests exercise _lexsort_depth, _should_fallback_to_positional
  • tests/indexing/test_chaining_and_caching.py tests Index caching properties and detecting if chained assignment happens (which IMO is out of scope for cuDF) so skip collecting these tests all together

Remove ~30 failing pandas unit tests

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Nov 10, 2025
@mroeschke mroeschke requested a review from a team as a code owner November 10, 2025 21:46
@mroeschke mroeschke added the improvement Improvement / enhancement to an existing function label Nov 10, 2025
@mroeschke mroeschke added the non-breaking Non-breaking change label Nov 10, 2025
@mroeschke mroeschke requested a review from rjzamora November 10, 2025 21:46
@mroeschke mroeschke added the cudf.pandas Issues specific to cudf.pandas label Nov 10, 2025
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 10, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Nov 10, 2025
@galipremsagar
Copy link
Contributor

  • The MultiIndex tests exercise _lexsort_depth, _should_fallback_to_positional

Same as #20572 (comment), if we know some attribute is private, let's mark them private to not go back and investigate these failures. Once we add, I imagine we will have these passes, but any non-passing test let's skip.

@galipremsagar galipremsagar requested review from a team as code owners November 17, 2025 22:54
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue Java Affects Java cuDF API. cudf-polars Issues specific to cudf-polars labels Nov 17, 2025
@galipremsagar galipremsagar changed the base branch from main to release/25.12 November 17, 2025 22:54
@vyasr
Copy link
Contributor

vyasr commented Nov 20, 2025

/merge

@rapids-bot rapids-bot bot merged commit f3ef15f into rapidsai:release/25.12 Nov 20, 2025
131 of 133 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Nov 20, 2025
@mroeschke mroeschke deleted the ref/cudf_pandas/private_multiindex branch November 26, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue cudf.pandas Issues specific to cudf.pandas cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants