Add stream synchronize to QUANTILES_TEST PercentileApprox gtests #20558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
davidwendt
added
3 - Ready for Review
bdice
approved these changes
Nov 13, 2025
mhaseeb123
approved these changes
Nov 13, 2025
Contributor
Author
|
/merge |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
) Adds stream-sync calls to the QUANTILES PercentileApprox tests to fix intermittent failures in debug builds and PTDS builds. Closes #18455 Closes #20504 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: #20558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds stream-sync calls to the QUANTILES PercentileApprox tests to fix intermittent failures in debug builds and PTDS builds.
Closes #18455
Closes #20504
Checklist