Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support k8s 1.32.2 #352

Merged
merged 2 commits into from
Mar 6, 2025
Merged

support k8s 1.32.2 #352

merged 2 commits into from
Mar 6, 2025

Conversation

jiaqiluo
Copy link
Member

@jiaqiluo jiaqiluo commented Mar 4, 2025

rancher/rancher#48825

Changes:

  1. Support k8s 1.32

Bump the k8s modules to 1.32.2
Bump the kubectl

  1. Fix the broken e2e test cases

Failed tests:

 Job Generation when fails because of invalid time window should apply successfully after edit
 Job Generation when fails because of invalid post complete delay should apply successfully after edit

The initContainer is only set when plan.Spec.Prepare, plan.Spec.Cordon, or plan.Spec.Drain is not nil code, which doesn't seem to be the case for the plan created in these tests.

@jiaqiluo jiaqiluo marked this pull request as ready for review March 5, 2025 19:22
@jiaqiluo jiaqiluo requested review from brandond and a team March 5, 2025 19:24
@brandond
Copy link
Member

brandond commented Mar 5, 2025

Seems like for some reason e2e was not running all the tests, but I'm not sure why. Logs for other recent PRs say:

Plugin: system-upgrade-controller
Status: passed
Total: 1
Passed: 1
Failed: 0
Skipped: 0

For this PR we have:

Plugin: system-upgrade-controller
Status: passed
Total: 16
Passed: 16
Failed: 0
Skipped: 0

@brandond
Copy link
Member

brandond commented Mar 5, 2025

@jiaqiluo can you merge or do you need me to do that?

@jiaqiluo
Copy link
Member Author

jiaqiluo commented Mar 5, 2025

@brandond, thanks for sharing the findings, that at least explains why the CI passed in the past.
I have the permission to merge PR and will do it once I get another approval from my team.

@jiaqiluo jiaqiluo merged commit b1a9781 into rancher:master Mar 6, 2025
3 checks passed
@jiaqiluo jiaqiluo deleted the support-132 branch March 6, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants