-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get UID/GID for current user in write file_test.go #228
base: main
Are you sure you want to change the base?
Get UID/GID for current user in write file_test.go #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop the build arg to allow it to run on arm64 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jakefhyde, I think this question is still valid. Please let me know if I misunderstand anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try and see if it works
Ah shoot, I forgot this test is shared between both platforms. On windows |
I'll opt for the former (for now). |
@HarrisonWAffel actually from looking at the docs, it appears it does nothing if uid and gid are |
b01b2e5
to
cc8842d
Compare
This can just get merged whenever, it's just to enable these tests to run locally. I've confirmed they work both with
go test ./...
andmake test
.