Generate SQL for searching in explicit arrays - part 2/2 - Verify parsed queries and generated SQL works correctly #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when you look for a string in field X, and while X isn't indexed, X[1], X[2], etc. are. Or we can treat the field X as a string of values "x1|x2|x3|x4" and see if it contains the search string "x" in one of the or-bar parts (not supporting partial matches).
Since we have explicitly indexed array-like fields, run sql tests on them.
* When we're doing a < or > test on an array field, we have to verify that it's numeric. Otherwise SQL will do an alpha comparison, and that isn't what we want. * Returning the errors from the parser as an aggregated error isn't very helpful. Convert to an error, so we can tell the user what actually happened. * Note with the fixture tests that there are some food names in "_v1_Foods" that aren't in "_v1_Foods_fields". These won't show up in the results because the join on the two tables will drop them, as they aren't in both tables. This is by design.
|
We're taking a different approach for array-based searching. Not doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Depends on #626
Related to #49116
The idea in this PR is to set up a database (of foods, but there are tables for other rancher-like things that
will get used in a later PR), make URL-like queries on them, translate the queries into SQL, run the SQL through
sqlite, and verify that we get the expected results.