Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.3] Migrate the mocking library to uber's #475

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Feb 3, 2025

Issue rancher/rancher#47442

Backports #291

Needed to migrate SQL cache from lasso to Steve (because it uses mocks)

* Migrate from golang/mock to uber/mock.

* Update go.mod

* Continue migration to uber/mock.

* Tweaks from running the go.uber.mock's mockgen.
@tomleb tomleb force-pushed the gomock-migration-backport branch from 8c74d4b to afba871 Compare February 3, 2025 19:54
@tomleb tomleb marked this pull request as ready for review February 3, 2025 20:03
@tomleb tomleb requested a review from a team as a code owner February 3, 2025 20:03
@tomleb tomleb changed the title Migrate the mocking library to uber's (#291) [v0.3] Migrate the mocking library to uber's Feb 3, 2025
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine

Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomleb tomleb merged commit d501012 into rancher:release/v0.3 Feb 3, 2025
1 check passed
@tomleb tomleb deleted the gomock-migration-backport branch February 3, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants