Pass Description as Positional Argument #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
changed the title
ryneeverett
added a commit
to ryneeverett/bugwarrior
that referenced
this pull request
Jun 6, 2020
See GothenburgBitFactory#733. I don't foresee this being fixable from bugwarrior but could be worked around in taskwarrior. I confirmed that this does pass with ralphbean/taskw#135.
ryneeverett
added a commit
to ryneeverett/bugwarrior
that referenced
this pull request
Jun 6, 2020
See GothenburgBitFactory#733. I don't foresee this being fixable from bugwarrior but could be worked around in taskw. I confirmed that this does pass with ralphbean/taskw#135.
taskw/utils.py
Outdated
| @@ -134,7 +134,7 @@ def encode_task_experimental(task): | |||
| task[k] = encode_task_value(k, task[k]) | |||
|
|
|||
| # Then, format it as a string | |||
| return [ | |||
| return [task.pop('description')] + [ | |||
There was a problem hiding this comment.
I'm a little confused about this one -- won't this cause us to not encode the task description in the generated task?
There was a problem hiding this comment.
The diff on this line looks a bit strange but if you look closely you'll see it's removing the description from the task dictionary and prepending it as a list item, so it is passed positionaly rather than in key:value format.
ryneeverett
force-pushed
the
positional-description
branch
from
57fa60f to
67e4353
Compare
Similarly to ralphbean#134, passing description via description:{description} doesn't appear to be documented and can lead to problems. See GothenburgBitFactory/bugwarrior#733 and consider the following scenario: ```sh $ task --version 2.5.1 $ task add description:"depends filter does not work with ID" The expression could not be evaluated. $ task add "depends filter does not work with ID" Created task 1. ``` I've tried variations of the previous with various quoting and shells and have gotten the same result.
ryneeverett
force-pushed
the
positional-description
branch
2 times, most recently
from
1ac1360 to
008bb90
Compare
ryneeverett
added a commit
to ryneeverett/bugwarrior
that referenced
this pull request
Apr 27, 2022
See GothenburgBitFactory#733. I don't foresee this being fixable from bugwarrior but could be worked around in taskw. I confirmed that this does pass with ralphbean/taskw#135.
ryneeverett
added a commit
to ryneeverett/bugwarrior
that referenced
this pull request
Apr 28, 2022
See GothenburgBitFactory#733. I don't foresee this being fixable from bugwarrior but could be worked around in taskw. I confirmed that this does pass with ralphbean/taskw#135.
ryneeverett
added a commit
to ryneeverett/bugwarrior
that referenced
this pull request
Apr 28, 2022
See GothenburgBitFactory#733. I don't foresee this being fixable from bugwarrior but could be worked around in taskw. I confirmed that this does pass with ralphbean/taskw#135.
ryneeverett
added a commit
to ryneeverett/bugwarrior
that referenced
this pull request
Apr 28, 2022
See GothenburgBitFactory#733. I don't foresee this being fixable from bugwarrior but could be worked around in taskw. I confirmed that this does pass with ralphbean/taskw#135. I've also confirmed that it passes with now that I've upgraded to taskwarrior-2.6.1. It seems that everyone, including myself, who reproduced this issue in the past was using taskwarrior-2.5.1.
|
This workaround was necessary for taskwarrior-2.5.1 but I've verified that it is no longer necessary as of at least taskwarrior-2.6.1. (I haven't gone to the effort of bisecting between the two.) At this point I wouldn't mind if this was closed as wontfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #131 so the tests will pass and #134 so I can run the test suite without corrupting my local database.
Similarly to #134, passing description via description:{description}
doesn't appear to be documented and can lead to problems.
See GothenburgBitFactory/bugwarrior#733 and consider the following scenario:
I've tried variations of the previous with various quoting and shells
and have gotten the same result.