Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate example with factory (#367) #368

Closed
wants to merge 3 commits into from
Closed

Conversation

kevincobain2000
Copy link
Member

Reference: #367

  • Update composer to PHP greater than 8

  • adds parameters for activating generation through factory

  • add example generation by factories

  • returns the original state

  • revert index alter

  • update readme

  • Add example to mock


piovezanfernando and others added 2 commits May 29, 2024 11:35
* Update composer to PHP greater than 8

* adds parameters for activating generation through factory

* add example generation by factories

* returns the original state

* revert index alter

* update readme

* Add example to mock

---------

Co-authored-by: Fernando Piovezan <fernando.piovezan>
@kevincobain2000
Copy link
Member Author

To @fernandopiovezan1
I have enabled CI tests on pull_requests too, so your next PR should be able to run the CI directly without merging to master.
Can you please check the failing tests?
Thanks

@piovezanfernando
Copy link

piovezanfernando commented May 29, 2024

Hi @kevincobain2000 I made the lint corrections as requested, but the first two CIs will have to be disabled, as PHP 7.4 was removed from the composer because it used PHP 8.0 methods, so it will not be possible to make the correction as there is no compatibility.

I made the correction but it doesn't come to this commit, I don't understand what the flow should be now.
Should I open a PR for develop or master? As soon as I know where the PR goes, I'll open it again

@kevincobain2000
Copy link
Member Author

I see. Hold on I ll remove that from matrix tonight

@piovezanfernando
Copy link

I can't send it to this PR since I lost track of my original branch, but the changes that are in this branch are now also in the other PR since I did the development rebase in my branch. So I believe this branch can be closed, as it will no longer be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants