Skip to content

Replace deprecated bundle package --all call #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

marcoroth
Copy link
Contributor

@marcoroth marcoroth commented Mar 4, 2025

Hey, thank you for this awesome gem!

I just started using rake-compiler-dock and it already massively simplified my life for precompiling one of my gems! ❤️

I noticed that the bundle package --all call which is referenced in the README was deprecated:

[DEPRECATED] The `--all` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set cache_all true`, and stop using this flag

This pull request updates the bundle package --all calls to bundle config set cache_all true and bundle package to avoid the deprecation warning when compiling a gem.

bundle package --all

[DEPRECATED] The `--all` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set cache_all true`, and stop using this flag
@flavorjones flavorjones merged commit 89eac8c into rake-compiler:main Mar 7, 2025
135 checks passed
@flavorjones
Copy link
Collaborator

Thank you!

@marcoroth marcoroth deleted the bundle-cache-all-config branch March 7, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants