fixes #68 & #69 Refactor DistributedLock #70
Merged
+193
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirides
commented
Apr 4, 2024
kirides
commented
- remove re-entrancy (fixes SQLiteDistributedLock doesn't play right with async #68)
- pause heartbeat timer while processing
- update expiration using SQL Update statement in a single step
- Added Heartbeat event (for testing)
- if we no longer own the lock, we immediately dispose the heartbeat timer (fixes Unable to update heartbeat - still happening in .NET 6.0 #69)
- remove re-entrancy - pause heartbeat timer while processing - update expiration using SQL Update statement in a single step - if we no longer own the lock, we immediately dispose the heartbeat timer - Added Heartbeat event (for testing) Signed-off-by: kirides <[email protected]>
kirides
force-pushed
the
issues/68/distributed_lock
branch
from
8138f1c to
7c3c90c
Compare
kirides
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.