Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move modal types into ui-components and refactor their usage #1330

Merged
merged 15 commits into from
Feb 19, 2025
Merged

Move modal types into ui-components and refactor their usage #1330

merged 15 commits into from
Feb 19, 2025

Conversation

hardingjam
Copy link
Contributor

@hardingjam hardingjam commented Feb 17, 2025 •
edited
Loading

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@hardingjam hardingjam requested a review from hardyjosh February 17, 2025 12:51
@hardingjam hardingjam self-assigned this Feb 17, 2025
@hardingjam hardingjam linked an issue Feb 17, 2025 that may be closed by this pull request
Move GUI form getters to a seperate file as exports #1133
Open
@hardingjam hardingjam removed a link to an issue Feb 17, 2025
Move GUI form getters to a seperate file as exports #1133
Open
@hardingjam hardingjam changed the title 1133 move gui form getters to a seperate file as exports Move modal types into ui-components and refactor their usage Feb 17, 2025
@hardingjam hardingjam requested a review from hardyjosh February 17, 2025 18:32
@hardingjam hardingjam mentioned this pull request Feb 18, 2025
Merged
4 tasks
@hardyjosh hardyjosh enabled auto-merge February 19, 2025 10:37
@hardingjam hardingjam mentioned this pull request Feb 19, 2025
Open
4 tasks
@hardyjosh hardyjosh merged commit 4d75471 into main Feb 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@hardingjam hardingjam

Labels
webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardingjam @hardyjosh