Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1303 order page isnt polling and can be out of sync #1329

Merged
merged 21 commits into from
Feb 20, 2025

Conversation

hardingjam
Copy link
Contributor

Motivation

Closes #1303 and #1309

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@hardingjam hardingjam requested a review from hardyjosh February 17, 2025 12:07
@hardingjam hardingjam self-assigned this Feb 17, 2025
@hardingjam hardingjam linked an issue Feb 17, 2025 that may be closed by this pull request
@hardyjosh
Copy link
Contributor

@hardingjam this still doesn't quite work - if i hit the refresh on the trades table, i can get a new trade without the vault balances being updated.

all of the refresh buttons on the page should be fully synced, there isn't really a use case for something on the page refreshing while something else doesn't - it's all related data

@hardingjam hardingjam force-pushed the 1303-order-page-isnt-polling-and-can-be-out-of-sync branch from 960590d to 766300a Compare February 19, 2025 16:11
@hardyjosh
Copy link
Contributor

@hardingjam still doesn't work, I tried hitting the trade refetch and expected to see the quotes refetch but that isn't happening

@hardyjosh hardyjosh enabled auto-merge February 20, 2025 20:19
@hardyjosh hardyjosh merged commit 7a773c6 into main Feb 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants