Deprecate Mailtrap::Mail::FromTemplate #54
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are going to introduce batch sending API soon. It introduces the notion of email
base
which like a regular email but withoutto
,cc
, andbcc
. This puts our hierarchy to the stretch. To simplify this I suggest to deprecateFromTemplate
class in favour of builders.Changes
Mailtrap::Mail::FromTemplate
How to test