add recovered/vaccinated option to checkin #355
Conversation
stringparser
changed the title
|
Seems we already have a checkbox for confirming vaccination (see screenshot below). @juanmendi could you test here https://rcvr-app-9zukytc9o-railslove.vercel.app/ for the modal setup and let me know if that's enough? I've updated the locales and added the new option.
|
|
@stringparser did you check if the data exporter part shows a correct value with this? |
I haven't worked yet with the exporter. Could you help with this? |
| switch (value) { | ||
| case 0: | ||
| case 1: | ||
| case 24: | ||
| case 48: { | ||
| return CoronaTestOptions[value] | ||
| } | ||
| default: { | ||
| return null | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
tried value in CoronaTestOptions and if (CoronaTestOptions[value]) but return value still showed any. This is what I could come up with without using typecasting.
|
Ok, could make it work locally (see screenshot below were the Onboarding component doesn't show the provide test option radio button). @bitboxer not sure if we need some other adjustment. Let me know. Here localhost checkin url for testing: Simply start the server as normal and as far as I can tell should work for you too.
|
| 0: 'NO_TEST', | ||
| 1: 'RECOVERED_OR_VACCINATED', | ||
| 24: '24_HOUR_TEST_NEEDED', | ||
| 48: '48_HOUR_TEST_NEEDED', |
There was a problem hiding this comment.
Maybe it's time to rewrite this into propper enums?
There was a problem hiding this comment.
Is saved as number on the database. Actually tried to use recovered as key first but didn't work. So somehow we need the keys to be a number.
|
@stringparser you just need to login as business owner and go to the export part. There you can request a new data dump and after that you can see the table there. I could show it to you via screen share if you want. |
ah I see. will check and if all looks good I'll merge |
can't figure it out. will merge since this was needed a while ago and check out with you separately. in case we need a fix we can deploy it separately. |
Ticket: railslove/recover-backlog#179
In progress still. Adding you guys for review so you can check it or say if there something is missing.
At the moment what I have to see is if we need something extra on the checkin page.