Fixes Issue #8

.github/workflows/test.yml

@@ -18,7 +18,7 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.1
+        ruby-version: 3.2
 
     - name: Upgrade Bundler
       run: |
@@ -36,4 +36,4 @@ jobs:
       run: chmod -R o-w /opt/hostedtoolcache/Ruby
 
     - name: Run tests with coverage
-      run: COVERAGE=true bundle exec rspec --order random spec
+      run: COVERAGE=true bundle exec rspec --order random spec

Gemfile

@@ -12,4 +12,6 @@ group :development, :test do
   gem "rspec", "~> 3.0"
   gem "simplecov"
   gem "standard", "~> 1.3"
+  gem "vcr"
+  gem "webmock"
 end

README.md

@@ -54,6 +54,27 @@ You will need to specify these values:
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
+## Testing
+
+This project uses RSpec for testing, with VCR to record HTTP interactions.
+
+To ensure your tests run consistently with CI, remove your local bundler cache before running tests:
+```
+rm -rf ~/.bundle/cache
+```
+
+If you do not clear the cache, VCR may record a 304 response from https://rubygems.org/versions,
+causing bundler to use the cached rubygems index. Since CI does not have this cache, cassette
+matching will fail and VCR will report unhandled HTTP requests.
+
+To re-record all VCR cassettes (update recorded HTTP interactions), run:
+
+```sh
+rake spec:vcr_record_new
+```
+
+This will refresh all cassette files used in tests.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/railsbump/checker. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/railsbump/checker/blob/master/CODE_OF_CONDUCT.md).

Rakefile

@@ -8,3 +8,10 @@ RSpec::Core::RakeTask.new(:spec)
 require "standard/rake"
 
 task default: %i[spec standard]
+
+namespace :spec do
+  task :vcr_record_new do
+    ENV["VCR_RECORD_NEW"] = "true"
+    Rake::Task[:spec].invoke
+  end
+end

lib/rails_bump/checker/bundle_locally_check.rb

@@ -79,7 +79,12 @@ def gemfile_content
         GEMFILE
 
         @dependencies.each do |gem_name, gem_version|
-          result += "gem '#{gem_name}', '#{gem_version}'\n" unless gem_name == "rails"
+          if gem_version.include?(",")
+            gem_versions = gem_version.split(", ").map { |i| "'#{i}'" }.join(", ")
+            result += "gem '#{gem_name}', #{gem_versions}\n" unless gem_name == "rails"
+          else
+            result += "gem '#{gem_name}', '#{gem_version}'\n" unless gem_name == "rails"
+          end
         end
 
         result
@@ -93,7 +98,7 @@ def try_bundle_install
         FileUtils.rm_rf File.join(tmp_dir, "Gemfile")
         FileUtils.rm_rf File.join(tmp_dir, "Gemfile.lock")
 
-        # Clean Bundler cache
+        # Remove unused gems
         `bundle clean --force`
 
         File.write(File.join(tmp_dir, "Gemfile"), gemfile_content)

spec/rails_bump/checker/bundle_locally_check_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-RSpec.describe RailsBump::Checker::BundleLocallyCheck do
+RSpec.describe RailsBump::Checker::BundleLocallyCheck, :vcr do
   describe "#check" do
     let(:deps) do
       {"cronex" => ">= 0.13.0", "fugit" => "~> 1.8", "globalid" => ">= 1.0.1", "sidekiq" => ">= 6"}
@@ -38,6 +38,17 @@
 
         expect(result.success?).to be_truthy
       end
+
+      context "when dependencies have complex requirements" do
+        let(:deps) do
+          {"faraday-net_http" => ">= 2.0, < 3.5"}
+        end
+
+        it "installs dependencies without errors" do
+          result = @checker.check
+          expect(result.success?).to be_truthy
+        end
+      end
     end
 
     context "when dependencies are empty" do

spec/rails_bump/checker/rails_release_check_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-RSpec.describe RailsBump::Checker::RailsReleaseCheck do
+RSpec.describe RailsBump::Checker::RailsReleaseCheck, :vcr do
   describe "#check" do
     let(:version) { "6.1.0" }
 

spec/spec_helper.rb

@@ -8,6 +8,15 @@
   end
 end
 
+# VCR setup
+require "vcr"
+VCR.configure do |c|
+  c.cassette_library_dir = "spec/vcr_cassettes"
+  c.hook_into :webmock
+  c.default_cassette_options = { record: ENV["VCR_RECORD_NEW"] ? :all : :once }
+  c.configure_rspec_metadata!
+end
+
 require "rails_bump/checker"
 
 RSpec.configure do |config|
@@ -20,4 +29,11 @@
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
+
+  if ENV["VCR_RECORD_NEW"]
+    config.before(:each) do
+      cache_path = File.expand_path('~/.bundler/cache')
+      FileUtils.rm_rf(cache_path) if Dir.exist?(cache_path)
+    end
+  end
 end