Skip to content

SEO Task: Correct H1s on Root Domain #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+36 −9
Open

SEO Task: Correct H1s on Root Domain #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e94ca17
fix h1 on index page
bhumi1102 Apr 21, 2025
0d2909b
add or update h1
bhumi1102 Apr 21, 2025
879f47d
keep h1 styles for h2 elements on home page
bhumi1102 May 16, 2025
afc5e0d
update h2 styles to micic h1 on home
bhumi1102 May 20, 2025
969c568
Apply suggestions from code review
bhumi1102 May 20, 2025
4f99812
copy h1 styles for all media sizes
bhumi1102 May 29, 2025
fff1ccd
resolve merge conflict from main
bhumi1102 May 29, 2025
40db60c
add Docs to h1 per review comment
bhumi1102 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<html lang="en">
{% include head.html %}

<body>
<body class="{% if page.id %}page-{{ page.id }}{% endif %}">
{% include notification.html %}
{% if page.id == 'home' %}
{% include banner.html %}
Expand Down
2 changes: 1 addition & 1 deletion _pages/docs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>
Everything you need<br> to get building.
Docs: Everything you need<br> to get building.
</h1>
</div>
</div>
Expand Down
19 changes: 17 additions & 2 deletions _sass/common/_headline.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,16 @@
line-height: 26px;
}

.page-home & {
h2 {
color: $color-red;
font-size: 47px;
font-weight: 700;
letter-spacing: -0.01em;
line-height: 43px;
}
}

a {

color: $color-black;
Expand All @@ -88,8 +98,6 @@
font-weight: 600;
}



@media(min-width: 1024px) {

font-size: 21px;
Expand All @@ -116,6 +124,13 @@
line-height: 44px;
}

.page-home & {
h2 {
font-size: 78px;
line-height: 72px;
}
}

}


Expand Down
12 changes: 12 additions & 0 deletions blog/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
description: "Discover the latest Ruby on Rails news, Rails Foundation updates, new versions, and feature announcements. All in one place."
---

<div class="docs heading common-padding--bottom common-padding--top-small">
<div class="container">
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>
Ruby on Rails News
</h1>
</div>
</div>
</div>
</div>

<div class="heading common-padding--bottom-small common-padding--top-small">
<div class="container">
<div class="heading__body">
Expand Down
10 changes: 5 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h4>Learn just what you need to get started, then keep leveling up as you go. <s
<div class="container">
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>You’re in good company.</h1>
<h2>You’re in good company.</h2>
<h4>Over the past two decades, Rails has taken countless companies to millions of users and billions in market valuations.</h4>
</div>
</div>
Expand Down Expand Up @@ -166,7 +166,7 @@ <h4>Over the past two decades, Rails has taken countless companies to millions o
<div class="container">
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>Building it together.</h1>
<h2>Building it together.</h2>

<h4>Over six thousand people have <a href="https://contributors.rubyonrails.org">contributed code to Rails</a>, and many more have served the community through evangelism, documentation, and bug reports. Join us!</h4>
</div>
Expand All @@ -182,7 +182,7 @@ <h4>Over six thousand people have <a href="https://contributors.rubyonrails.org"
<div class="container">
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>Everything you need.</h1>
<h2>Everything you need.</h2>
<h4><strong>Rails is a full-stack framework.</strong> It ships with all the tools needed to build amazing web apps on both the front and back end.</h4>
</div>

Expand Down Expand Up @@ -309,7 +309,7 @@ <h3>Action Dispatch routes URLs.</h3>
<div class="container">
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>Optimized for happiness.</h1>
<h2>Optimized for happiness.</h2>
</div>

<div class="heading__content heading__content--has-headline common-content common-content--size-large">
Expand All @@ -327,7 +327,7 @@ <h1>Optimized for happiness.</h1>
<div class="container">
<div class="heading__body">
<div class="heading__headline common-headline">
<h1>Let’s get started.</h1>
<h2>Let’s get started.</h2>
</div>
</div>
</div>
Expand Down