Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Specify Bundler version #547

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −5
Open

CI: Specify Bundler version #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb9e102
CI: Specify Bundler version
mamhoff Feb 15, 2025
647b886
CI: Fix Rails 7.0 and 6.1
mamhoff Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,35 +9,43 @@ jobs:
include:
- ruby: 2.5
gemfile: "gemfiles/Gemfile.rails-6.1-sprockets-3"
bundler: "2.3.0"
- ruby: 2.5
gemfile: "gemfiles/Gemfile.rails-6.1-sprockets-4"

bundler: "2.3.0"
- ruby: 2.7
gemfile: "gemfiles/Gemfile.rails-7.0-sprockets-3"
bundler: "2.4.8"
- ruby: 2.7
gemfile: "gemfiles/Gemfile.rails-7.0-sprockets-4"

bundler: "2.4.8"
- ruby: 2.7
gemfile: "gemfiles/Gemfile.rails-7.1-sprockets-3"
bundler: "2.4.8"
- ruby: 2.7
gemfile: "gemfiles/Gemfile.rails-7.1-sprockets-4"

bundler: "2.4.8"
- ruby: 3.1
gemfile: "gemfiles/Gemfile.rails-7.2-sprockets-3"
bundler: default
- ruby: 3.1
gemfile: "gemfiles/Gemfile.rails-7.2-sprockets-4"

bundler: default
- ruby: 3.2
gemfile: "gemfiles/Gemfile.rails-8.0-sprockets-3"
bundler: default
- ruby: 3.2
gemfile: "gemfiles/Gemfile.rails-8.0-sprockets-4"

bundler: default
- ruby: 3.2
gemfile: Gemfile
bundler: default
- ruby: 3.3
gemfile: Gemfile
bundler: default
- ruby: head
gemfile: Gemfile
bundler: default

env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
Expand All @@ -49,6 +57,8 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
cache-version: ${{ matrix.ruby }}-${{ matrix.ruby }}-${{ matrix.gemfile }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably wanted?

-${{ matrix.ruby }}-${{ matrix.ruby }}-${{ matrix.gemfile }}
+${{ matrix.ruby }}-${{ matrix.bundler }}-${{ matrix.gemfile }}

bundler: ${{ matrix.bundler }}
- name: Run tests
run: bundle exec rake
continue-on-error: ${{ matrix.gemfile == 'Gemfile' }}
2 changes: 2 additions & 0 deletions gemfiles/Gemfile.rails-6.1-sprockets-3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ gemspec path: '..'
gem 'actionpack', '~> 6.1.0'
gem 'railties', '~> 6.1.0'
gem 'sprockets', '~> 3.0'

gem 'concurrent-ruby', '< 1.3.5'
2 changes: 2 additions & 0 deletions gemfiles/Gemfile.rails-6.1-sprockets-4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ gemspec path: '..'
gem 'actionpack', '~> 6.1.0'
gem 'railties', '~> 6.1.0'
gem 'sprockets', '~> 4.0'

gem 'concurrent-ruby', '< 1.3.5'
2 changes: 2 additions & 0 deletions gemfiles/Gemfile.rails-7.0-sprockets-3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ gemspec path: '..'
gem 'actionpack', '~> 7.0.0'
gem 'railties', '~> 7.0.0'
gem 'sprockets', '~> 3.0'

gem 'concurrent-ruby', '< 1.3.5'
2 changes: 2 additions & 0 deletions gemfiles/Gemfile.rails-7.0-sprockets-4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ gemspec path: '..'
gem 'actionpack', '~> 7.0.0'
gem 'railties', '~> 7.0.0'
gem 'sprockets', '~> 4.0'

gem 'concurrent-ruby', '< 1.3.5'
Loading