Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panel header overflow issue in Chrome #138

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Conversation

jhawthorn
Copy link
Member

This should fix an issue with the panel header under Chrome (at least on macOS).

Screen Shot 2020-02-13 at 3 35 12 PM

I've tested this change in the inspector, but not "for reals", but I'm pretty sure it will work 🤞.

The need for this fix would probably be obsoleted by #137, but this is a much smaller change

cc @eileencodes @smashwilson who both spotted the issue

@robin850 robin850 merged commit 090be02 into rails:master Mar 14, 2020
@robin850
Copy link
Member

Thanks for spotting and fixing this !

Tested locally and confirm that this works properly with your fix. Version 1.1.0 has just been released with this fix.

kaspth referenced this pull request in rails/rails Mar 14, 2020
Cross-refs zzak/sdoc#138.

[John Hawthorn]
@jonathanhefner
Copy link
Member

For posterity: I was able to reproduce the issue in Chromium 80 on Linux, but not Firefox. I suspect it is a rendering bug in Chrome, because the issue corrects itself if you toggle margin-left: 25px; off and then back on for .panel .header input.

If for some reason the current fix doesn't work "for reals" (i.e. only works when using the inspector), an alternative might be to remove margin-left: 25px; from .panel .header input, and add padding-left: 25px; box-sizing: border-box; to .panel .header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants