Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extract! accept objects with internal hash implementation #440

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions lib/jbuilder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,8 @@ def array!(collection = [], *attributes)
#
# json.(@person, :name, :age)
def extract!(object, *attributes)
if ::Hash === object
_extract_hash_values(object, attributes)
else
_extract_method_values(object, attributes)
attributes.each do |key|
_set_value key, _extract_value(object, key)
end
end

Expand Down Expand Up @@ -252,12 +250,8 @@ def target!

private

def _extract_hash_values(object, attributes)
attributes.each{ |key| _set_value key, object.fetch(key) }
end

def _extract_method_values(object, attributes)
attributes.each{ |key| _set_value key, object.public_send(key) }
def _extract_value(object, attribute)
object.respond_to?(:[]) ? object[attribute] : object.public_send(attribute)
end

def _merge_block(key)
Expand Down
22 changes: 22 additions & 0 deletions test/jbuilder_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ def initialize(name, age)
end
end

class PersonWithHash
def initialize(name, age, object_id)
@collection = { name: name, age: age, object_id: object_id }
end

delegate :[], :fetch, to: :@collection
end

class RelationMock
include Enumerable

Expand Down Expand Up @@ -121,6 +129,20 @@ class JbuilderTest < ActiveSupport::TestCase
assert_equal 34, result['age']
end

test 'extracting from object with internal hash' do
person = PersonWithHash.new('David', 32, 1)
ruby_object_id = person.object_id

result = jbuild do |json|
json.extract! person, :name, :age, :object_id
end

assert_equal 'David', result['name']
assert_equal 32, result['age']
assert_equal 1, result['object_id']
assert_not_equal ruby_object_id, result['object_id']
end

test 'nesting single child with block' do
result = jbuild do |json|
json.author do
Expand Down