Improved detection logic for package manager

[navidemad]

rails/jsbundling-rails#213 (comment)

Summary

This PR enhances the CSS Bundling Rails gem by implementing comprehensive support for multiple JavaScript package managers (Yarn, Bun, PNPM, and NPM) with improved detection logic and consistent behavior.

Changes

• Refactored package manager detection: Uses a more reliable approach by first checking lock files, then available executables
• Prioritized Yarn detection: Since most projects are still using Yarn, it's checked before Bun
• Fixed Bun detection: Removed yarn.lock from Bun management to prevent misidentification
• Implemented strategy pattern: Created dedicated installation strategies for each package manager
• Standardized command structure: Unified approach to running commands across different package managers
• Code organization: Moved related functionality into constants and clean helper methods
• Parameter improvements: Updated method signatures to use named parameters for better readability
• Performance optimization: Memoized package_manager method to avoid redundant detection

Technical Details

• Created TOOLS_COMMANDS constant mapping each package manager to its specific commands
• Implemented SCRIPT_STRATEGIES to handle package.json script modifications per package manager
• Refactored detection logic into tool_determined_by_config_file and tool_determined_by_executable
• Changed priority order in detection to prefer Yarn as the default when multiple options are available
• Added proper frozen string literal comment for performance

This change enhances developer experience by providing better support for their preferred package manager while maintaining backward compatibility.

[dhh]

This is interesting, but too complicated.

[navidemad]

I get what you mean, i commited a new version a bit more simpler to read.

[jbarrieault]

The Bun lockfiles should come before yarn.lock, since Bun optionally generates a yarn.lock file.

[navidemad]

Good catch, i update

[le0pard]

Lets review it again, so we fixed #169