Use a test setup similar to actiondispatch's Cookie Store tests

[stevenharman]

I took another look at the changes we had to make in #220 and compared that to how things work in actiondispatch's Cookie Store tests and realized we were close, but missing how we were setting the options for our store. So I've revamped the setup to be in line with what's in Rails' own tests. This should make it easier to keep things in line and working, going forward.

See the following two files for how Cookie Store tests (and their base ActionDispatch::IntegrationTest) work today (as of Rails 8.0):

• https://github.com/rails/rails/blob/8-0-stable/actionpack/test/dispatch/session/cookie_store_test.rb
• https://github.com/rails/rails/blob/8-0-stable/actionpack/test/abstract_unit.rb

The big downside to this is… it depends on some changes to how #with_routing, provided by Rails, works. Meaning it only works with Rails 7.2+. ☹️

[stevenharman]

@byroot I went down this path b/c I'm trying to fix a bug with how we handle the :same_site option (see #214).

When using the test setup from #220 (as it is on master right now) the tests fail because we seem to be using a Rack Session that's set up as part of the initial build_app, rather than the Rack Session object that gets built during the build_app inside our with_test_route_set setup block. And because of that, the same_site: option we pass in during a test isn't being used.

So, I think there's still some sort of state sticking around between tests, making it impossible to write tests for the :same_site option.

[byroot]

Meaning it only works with Rails 7.2+. ☹️

I don't mind dropping older Rails versions.

[stevenharman]

I was able to get the test suite passing as far back as Rails 7.0 by patching a change to how with_routing works, from Rails 7.2. That said, I'm also 💯 in favor of at least dropping Rails 7.0 support now that it's EoL'd. If you agree, let me know and I'll do that and then we can merge this as a "clean slate" for testing going forward.

[byroot]

in favor of at least dropping Rails 7.0 support now that it's EoL'd.

Yeah , no problem with that

[stevenharman]

Done. And I was able to clean up the text matrix overall by only including Ruby 2.7 and 3.0 for Rails 7.1. This should (hopefully) make it more clear which Rubies we can drop as we drop older Rails. 😄