Skip to content

Fix load path for precompiled code on Windows #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

andyundso
Copy link
Member

@andyundso andyundso commented Apr 8, 2025

Closes #581.

The precompiled FreeTDS binary is located in the bin folder on Windows instead of lib. So when loading tiny_tds on Windows, an error was thrown, as the precompiled code was not found. There is a step in our CI that should have catched this error, as it does install tiny_tds from the built .gem-file and checks if it loads successfully. But this CI did not fail. Reason is that we also always cloned the entire source code for tiny_tds from Git, so likely irb just invoked the source code installed of the installed gem.

This PR:

  • Removes the checkout step for two installation scenarios on Windows and the one on Linux
  • Adds bin to the dll loads path when requiring tiny_tds

@aharpervc
Copy link
Contributor

Re-running the single failed job, hopefully an ephemeral failure

@andyundso andyundso merged commit 1da793b into rails-sqlserver:master Apr 10, 2025
343 of 345 checks passed
@andyundso andyundso deleted the fix-windows-build branch April 10, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 3.4 Load Errors
2 participants