Fix load path for precompiled code on Windows #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #581.
The precompiled FreeTDS binary is located in the
bin
folder on Windows instead oflib
. So when loadingtiny_tds
on Windows, an error was thrown, as the precompiled code was not found. There is a step in our CI that should have catched this error, as it does installtiny_tds
from the built.gem
-file and checks if it loads successfully. But this CI did not fail. Reason is that we also always cloned the entire source code fortiny_tds
from Git, so likelyirb
just invoked the source code installed of the installed gem.This PR:
checkout
step for two installation scenarios on Windows and the one on Linuxbin
to the dll loads path when requiringtiny_tds