[WIP] coerce types for config parameters; add missing config parameters recognized by TinyTDS -- Issue #740 #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ognized by TinyTDS -- Issue rails-sqlserver#740 Signed-off-by: mystic knight <[email protected]>
PaulCharlton
changed the title
Author
|
changed to [WIP] to add unit tests for additional parameters and checks for the type coercion expected values |
Member
|
@PaulCharlton do you need help with this? |
Author
|
@wpolicarpo thanks for asking! --- it has been more of a bandwidth issue and getting distracted with other things -- if you need it sooner, by all means add some additional commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coerce types for config parameters; add missing config parameters recognized by TinyTDS -- Issue #740
see also: rails-sqlserver/tiny_tds#461