Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Securify Entity classification #367

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

micbakos-rdx
Copy link
Contributor

@micbakos-rdx micbakos-rdx commented Jan 31, 2025

Currently In progress

  • Securify classification in transaction manifest with a temporary solution that is going to be replaced with a proper solution from RET.
  • A function to mark an entity as securified.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (99c1a7c) to head (3538ebb).

Files with missing lines Patch % Lines
...c/low_level/execution_summary/execution_summary.rs 65.21% 8 Missing ⚠️
...tem/os/factors/src/sargon_os_mark_as_securified.rs 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   92.61%   92.64%   +0.03%     
==========================================
  Files        1180     1181       +1     
  Lines       26658    26706      +48     
  Branches       77       77              
==========================================
+ Hits        24690    24743      +53     
+ Misses       1957     1952       -5     
  Partials       11       11              
Flag Coverage Δ
kotlin 97.63% <ø> (ø)
rust 92.31% <77.55%> (+0.03%) ⬆️
swift 92.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micbakos-rdx micbakos-rdx force-pushed the mib/ABW-4058-analyze-securify branch from 6ed8fe8 to 3538ebb Compare February 4, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant