fix(select): pass __selectScope to PopperContent component #3670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
__selectScope
property was not being passed through toPopperContent
, causing scope-related errors when using custom scopes with Select components.Root Cause
The spread operator
...contentProps
was inadvertently filtering out the__selectScope
property, which is required for proper component scoping in Radix UI primitives.Solution
Updated the component to explicitly pass
__selectScope
toPopperContent
, ensuring proper scope inheritance.Use Case
This fix enables the following pattern to work correctly: