feat(ui): Funding Pool v0 #975

NunoAlexandre · 2020-09-30T08:09:35Z

Closes #974
Superseds #952

ui/src/funding/pool.ts

Now, as one clicks on "connect wallet" and gets the QRCode modal, when one dismisses that modal and gets back to the starting screen, the "connect wallet" button is now just spinning, as the call to "wallet.connect()" has set the wallet's state to "Connecting". To avoid this, we only set the state to connecting once the user has approved the connection and we must initialize all things. This makes sense from a practical perspective as well: we are not in fact connecting until there's green light from the other side, but just awaiting for the user to approve the connection. Anyway, for the UX this fixes the problem and does not cause any quirk.

Dumber is better

NunoAlexandre · 2021-01-18T08:35:02Z

One question regarding the release of the feature: if it can only be used in development mode because of the requirements of running it with ethereum:start, local walletconnect wallet and the sandbox/.local-eth-account, what's the point of having the feature flag in the settings if this can't be used in a packaged production app?

Or will there be follow-up PRs to address this before we release it to the public?

I am with you on this. The idea behind the feature flag was to have the feature available to end users but only for a selected or curious few who would like to give it a spin and help us validate it. For that, indeed, we'd need to have it pointing to a testnet.

So, answering your question, there will be a follow-up PR offering an environment option for the funding feature (something like localhost / testnet) before it should be made public. However, I don't want to have this becoming a blocker to release other app deliverables, so we could, for now, have it behind the isExperimental flag until said PR comes in.

How does that sound?

Edit: Done in 077053b.

NunoAlexandre · 2021-01-18T08:55:01Z

@rudolfs @geigerzaehler thanks for the second round! I have addressed/replied to all your comments.

Waiting on @brandonhaslegs to have a look at #975 (comment).

rudolfs

Great work!
I think once we sort out #975 (comment), it's a "go" from my side.

package.json

FUNDING.md

Co-authored-by: Rūdolfs Ošiņš <[email protected]>

rudolfs

LGTM 🚀

geigerzaehler

💸

ui/DesignSystem/Primitive/Icon/CurrencyDAI.svelte

ui/Modal/Funding/Link/EthToRadicle.svelte

ui/Screen/Funding/Pool/Outgoing/GetStarted.svelte

Co-authored-by: Merle Breitkreuz <[email protected]>

NunoAlexandre · 2021-01-20T13:05:18Z

@MeBrei @rudolfs @geigerzaehler appreciate your greenest lights and get this baby monster merged 🥰

NunoAlexandre · 2021-01-20T13:39:33Z

merged in 5b4a327 🎉 thank you all!

NunoAlexandre added feature Something that doesn't exist yet ui labels Sep 30, 2020

NunoAlexandre assigned geigerzaehler Sep 30, 2020

xla changed the title ~~[wip] feat(ui): Funding Pool v0~~ feat(ui): Funding Pool v0 Sep 30, 2020

NunoAlexandre force-pushed the feat/funding branch from 15f3278 to 6d40143 Compare October 2, 2020 07:16

geigerzaehler marked this pull request as ready for review October 2, 2020 09:53

NunoAlexandre commented Oct 9, 2020

View reviewed changes

ui/src/funding/pool.ts Outdated Show resolved Hide resolved

geigerzaehler assigned NunoAlexandre and unassigned geigerzaehler Oct 26, 2020

NunoAlexandre added 20 commits November 10, 2020 08:58

QRcode modal nit improvements

8bbc669

Update added/removed Receiver styling

6ebf8ac

Reduce transactions status updates polling

47f6cee

Merge remote-tracking branch 'origin/master' into feat/funding

0978ae4

Update upcoming support design

e272ff0

Redesign Wallet Panel

e5911c1

Fix screen layout and elements positioning

441a82b

Make the Incoming component dumber

1dfa927

Dumber is better

wip: Update outgoing support style

c859bf7

Make Receiver(s) editable or view-only

73f238b

Merge remote-tracking branch 'origin/master' into feat/funding

50b191d

Please the lint and fix broken pieces

3f5f306

Drop "awaiting scan" section from QRCode modal

05d52f8

Make wallet a singleton

2554b8a

Add 'link' icon

47c445a

Add 'Socks' Illustration

a153b4c

Add LinkAddress mock Modal

8574cdb

Merge remote-tracking branch 'origin/master' into feat/funding

21b2005

Merge remote-tracking branch 'origin/master' into feat/funding

41fb295

Prune docstring

dbf7eab

Move all funding things behind isExperimental

077053b

rudolfs reviewed Jan 18, 2021

View reviewed changes

package.json Show resolved Hide resolved

FUNDING.md Outdated Show resolved Hide resolved

NunoAlexandre and others added 2 commits January 18, 2021 10:55

Update FUNDING.md

eb50360

Co-authored-by: Rūdolfs Ošiņš <[email protected]>

Fix issue with inappropriate scrolling

e3d3085

rudolfs previously approved these changes Jan 18, 2021

View reviewed changes

Delete unecessary tx.wait() calls

77b6f62

NunoAlexandre dismissed rudolfs’s stale review via 77b6f62 January 18, 2021 14:58

NunoAlexandre requested review from geigerzaehler and rudolfs January 18, 2021 15:16

rudolfs previously approved these changes Jan 18, 2021

View reviewed changes

geigerzaehler previously approved these changes Jan 18, 2021

View reviewed changes

MeBrei reviewed Jan 20, 2021

View reviewed changes

ui/DesignSystem/Primitive/Icon/CurrencyDAI.svelte Outdated Show resolved Hide resolved

ui/Modal/Funding/Link/EthToRadicle.svelte Show resolved Hide resolved

ui/Screen/Funding/Pool/Outgoing/GetStarted.svelte Outdated Show resolved Hide resolved

Update ui/Screen/Funding/Pool/Outgoing/GetStarted.svelte

bace2c0

Co-authored-by: Merle Breitkreuz <[email protected]>

NunoAlexandre dismissed stale reviews from geigerzaehler and rudolfs via bace2c0 January 20, 2021 09:58

geigerzaehler linked an issue Jan 20, 2021 that may be closed by this pull request

Get Rollup and Node builtin modules to work #884

Closed

NunoAlexandre added 4 commits January 20, 2021 13:50

Update radicle-contract dependency

d18d4d8

Cap CurrencyDai long line

9a3953b

Fix wrong reference

74150fb

Improve wallet error messages

1226e87

fixup!

cf3d026

rudolfs approved these changes Jan 20, 2021

View reviewed changes

MeBrei approved these changes Jan 20, 2021

View reviewed changes

NunoAlexandre closed this Jan 20, 2021

NunoAlexandre deleted the feat/funding branch January 20, 2021 13:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ui): Funding Pool v0 #975

feat(ui): Funding Pool v0 #975

Uh oh!

NunoAlexandre commented Sep 30, 2020 •

edited

Loading

Uh oh!

Uh oh!

NunoAlexandre commented Jan 18, 2021 •

edited

Loading

Uh oh!

NunoAlexandre commented Jan 18, 2021

Uh oh!

rudolfs left a comment

Uh oh!

Uh oh!

Uh oh!

rudolfs left a comment

Uh oh!

geigerzaehler left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NunoAlexandre commented Jan 20, 2021

Uh oh!

NunoAlexandre commented Jan 20, 2021 •

edited

Loading

Uh oh!

Uh oh!

feat(ui): Funding Pool v0 #975

feat(ui): Funding Pool v0 #975

Uh oh!

Conversation

NunoAlexandre commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

NunoAlexandre commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NunoAlexandre commented Jan 18, 2021

Uh oh!

rudolfs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rudolfs left a comment

Choose a reason for hiding this comment

Uh oh!

geigerzaehler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NunoAlexandre commented Jan 20, 2021

Uh oh!

NunoAlexandre commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

NunoAlexandre commented Sep 30, 2020 •

edited

Loading

NunoAlexandre commented Jan 18, 2021 •

edited

Loading

NunoAlexandre commented Jan 20, 2021 •

edited

Loading