Skip to content
This repository was archived by the owner on Feb 28, 2021. It is now read-only.

Run end_to_end tests sequentially #215

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Conversation

NunoAlexandre
Copy link
Contributor

@NunoAlexandre NunoAlexandre commented Feb 10, 2020

Closes #214

Use the serial_test crate to mark specific tests to run sequentially instead of in parallel.

On the reasons for this PR, see #214.

Copy link

@geigerzaehler geigerzaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also document this in DEVELOPING.md?

@NunoAlexandre
Copy link
Contributor Author

@geigerzaehler can do! See #214 (comment).

@NunoAlexandre NunoAlexandre force-pushed the fix/end-to-end-tests branch 2 times, most recently from 47cc4b6 to 52f8cdc Compare February 10, 2020 15:01
This crate allows us to easily define a specific test to run in a serial
fashion instead of in parallel.
@NunoAlexandre
Copy link
Contributor Author

@geigerzaehler ready for your review.

@NunoAlexandre NunoAlexandre changed the title cli: Add --threads=1 option to cargo test command Run end_to_end tests sequentially Feb 10, 2020
Copy link

@geigerzaehler geigerzaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@NunoAlexandre NunoAlexandre merged commit 72e5e63 into master Feb 10, 2020
@NunoAlexandre NunoAlexandre deleted the fix/end-to-end-tests branch February 10, 2020 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can’t run end-to-end tests concurrently
2 participants