Skip to content

Commit

Permalink
ci: temporarily disable tests that depend on angular-in-memory-web-api (
Browse files Browse the repository at this point in the history
angular#22573)

angular-in-memory-web-api is not yet compatible with rxjs v6 and rxjs v6 backwards compatibility package is not yet ready to be used.

PR Close angular#22573
  • Loading branch information
IgorMinar committed Mar 20, 2018
1 parent 4a7be48 commit c445314
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion aio/content/examples/http/e2e/app.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ let checkLogForMessage = (message: string) => {
expect(page.logList.getText()).toContain(message);
};

describe('Http Tests', function() {
// TODO(i): temorarily disable these tests because angular-in-memory-web-api is not compatible with rxjs v6 yet
// and we don't have the backwards compatibility package yet.
// Reenable after rxjs v6 compatibility package is out or angular-in-memory-web-api is compatible with rxjs v6
xdescribe('Http Tests', function() {
beforeEach(() => {
browser.get('');
});
Expand Down
5 changes: 4 additions & 1 deletion aio/content/examples/toh-pt6/e2e/app.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ class Hero {
}
}

describe('Tutorial part 6', () => {
// TODO(i): temorarily disable these tests because angular-in-memory-web-api is not compatible with rxjs v6 yet
// and we don't have the backwards compatibility package yet.
// Reenable after rxjs v6 compatibility package is out or angular-in-memory-web-api is compatible with rxjs v6
xdescribe('Tutorial part 6', () => {

beforeAll(() => browser.get(''));

Expand Down

0 comments on commit c445314

Please sign in to comment.