fix(parse_def): prevent buffer overflow in register name copy #23942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer Overflow in arch_parse_reg_profile and parse_def
Description:
In the
parse_def
function,r->name
is a buffer that holds the name of a register. However, it is only 32 bytes in size. But in the arch_parse_reg_profile function, there is a buffertmp
which is128
bytes long and is used to hold parsed tokens from thereg_profile
string.As you see in
parse_def
, The strcpy function is used to copy the string fromtok[1]
intor->name
and there is no check to ensure thattok[1]
will fit intor->name
(which is only 32 bytes). To fix this issue, I replacedstrcpy
withsnprintf
, which allows you to specify the maximum size of the destination buffer, ensuring that the string is copied safely and that the buffer boundary is respected.